[PATCH 0/2] bump ci asciidoctor version

From: Jeff King <peff@peff.net>
Date: Sep 2, 2026, 07:11 UTC
Message-ID: <20260902071113.GA70165@coredump.intra.peff.net>
In-Reply-To: <aparyEbGiiFZpiCZ@pks.im>

On Tue, Sep 01, 2026 at 12:41:12PM +0200, Patrick Steinhardt wrote:

Show 15 quoted lines

> > But these days I'd guess everybody is using v2.0.x (which seems to work
> > fine) for local builds. We probably ought to do the same in CI. If we
> > have to catch issues in one, I'd rather it be the one people are likely
> > to actually use.
> 
> > It's possible that we could benefit from building with both in order to
> > support the older version. But given its age I doubt it's worth it. We
> > can still take bug fixes if somebody finds a problem, but we don't
> > necessarily need to spend cycles building every commit with 1.5.8.
> 
> I was wondering about whether I should bump its version while at it. In
> fact, we could just install it from the Ubuntu sources nowadays, too. I
> ultimately decided to not do that though and just fix the failing CI
> pipeline for now, but I agree that it's something we might want to
> follow up on.

I think your fix kept to the minimum, which is good. I agree we should just install it from the system package manager. I _thought_ that might make your fix here obsolete, but we also install the concurrent-ruby gem. That comes from 974cdca345 (doc: introduce a synopsis typesetting, 2024-09-24) which also introduced some custom ruby code in asciidoctor extensions. But it's not clear to me why it's necessary (and I build the docs happily on my local system without it installed). +cc Jean-Noël for any wisdom.

I guess installing asciidoctor from Ubuntu would also bring in ruby as a dependency. So I suppose it does make your patch obsolete, but it also doesn't hurt to be explicit that we expect "gem install" to work.

Anyway, here is a fix for the version which can be applied on top of ps/ci-depends-on-ruby.

-Peff