Re: [PATCH v2 00/10] Change midx.c and midx-write.c to not use global variables

> On Tue, Nov 19, 2024 at 4:38 PM Karthik Nayak <karthik.188@gmail.com> wrote:
> >
> > Similar to the earlier patch series on cleaning up packfile.c and
> > removing usage of global variables [1], we change the midx.c and
> > midx-write.c files to no longer use global variables.
> >
> > This is done by the following:
> >   - Usage of repository variable already available in existing structs.
> >   - Passing down repository variable from other subsystems.
> >   - Modifying all subcommands to obtain repository variable from the
> >   command in `builtins/` and passing down the variable from there.
> >
> > The biggest change is in the first commit, wherein we modify all
> > subcommands to add the repository variable. Since the subcommand
> > definition are not often changed, it shouldn't cause too many conflicts
> > with in flight topics.
>
> Overall I like the way it's done. I found a few improvements that
> could be made to some commit messages though.