Re: [PATCH v2 09/10] midx: pass down `hash_algo` to `get_split_midx_filename_ext`

From: karthik nayak <karthik.188@gmail.com>
Date: Nov 21, 2024, 15:41 UTC
Message-ID: <CAOLa=ZRr0LYSnC47K-ifZ-v+pCWx7msBpQc+65-biWK+dm4XMA@mail.gmail.com>
In-Reply-To: <Zz5hYfHLL1vsxdY5@nand.local>

Taylor Blau <me@ttaylorr.com> writes:

Show 15 quoted lines

> On Wed, Nov 20, 2024 at 07:15:40PM +0100, Christian Couder wrote:
>> On Tue, Nov 19, 2024 at 4:47 PM Karthik Nayak <karthik.188@gmail.com> wrote:
>> >
>> > Similar to the previous commit, pass down `hash_algo` to
>> > `get_split_midx_filename_ext` and use `hash_to_hex_algop`.
>>
>> I think we prefer explanations in commit messages to be a bit more
>> self-contained, and not to rely much only on other commit messages, or
>> links to a mailing list thread on a mailing list archive, or other
>> external content. It's better to err on the side of copying more.
>
> I agree, but in this instance think it would be better to simply
> combine the two into one. I do not see a reason why these commits should
> be split.
>

Fair enough, let me combine the two commits and rewrite the message to make it clearer.