Re: [PATCH v2 03/10] midx-write: use `revs->repo` inside `read_refs_snapshot`

From: shejialuo <shejialuo@gmail.com>
Date: Nov 20, 2024, 12:58 UTC
Message-ID: <Zz3dAZGAG3BupQqE@ArchLinux>
In-Reply-To: <20241119-374-refactor-midx-c-and-midx-write-c-to-not-depend-on-global-state-v2-3-e2f607174efc@gmail.com>

On Tue, Nov 19, 2024 at 04:36:42PM +0100, Karthik Nayak wrote:

> The `read_refs_snapshot` uses the `parse_oid_hex` function which
> internally uses global variables. Let's instead use

Nit: s/variables/variable

> `parse_oid_hex_algop` and provide the hash algo via `revs->repo`.
> 
> Also, while here, fix a missing newline after the functions definition.
>

Nit: s/functions/function

> Signed-off-by: Karthik Nayak <karthik.188@gmail.com>

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.