Re: [PATCH 2/8] midx-write: add repository field to `write_midx_context`
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
Show 20 quoted lines
> On 2024-11-15 at 13:42:15, Karthik Nayak wrote:
>> The struct `write_midx_context` is used to pass context for creating
>> MIDX files. Adding the repository field here ensures that most functions
>> within `midx-write.c` have access to the field and can use that instead
>> of the global `repository` variable. This involves passing the
>> `repository` field to `write_midx_internal`. To do this, we add
>> `the_repository` usage to two non-static functions, which we'll remove
>> in upcoming commits.
>>
>> With this, modify the static functions in `midx-write.c` to not use
>> global variables. This means, either we use existing alternatives (like
>> `repository` struct), or we pass down required fields from other
>> functions.
>>
>> Signed-off-by: default avatarKarthik Nayak <karthik.188@gmail.com>
>
> It looks like the sign-off here may have gotten corrupted.
> --
> brian m. carlson (they/them or he/him)
> Toronto, Ontario, CA
Indeed, will fix. Thanks!
karthik nayak <karthik.188@gmail.com>