Re: [PATCH v2 10/10] midx: inline the `MIDX_MIN_SIZE` definition

From: shejialuo <shejialuo@gmail.com>
Date: Nov 20, 2024, 13:13 UTC
Message-ID: <Zz3gguyjTKJ8RY-z@ArchLinux>
In-Reply-To: <20241119-374-refactor-midx-c-and-midx-write-c-to-not-depend-on-global-state-v2-10-e2f607174efc@gmail.com>

On Tue, Nov 19, 2024 at 04:36:49PM +0100, Karthik Nayak wrote:

> The `MIDX_MIN_SIZE` definition is used to check the midx_size in
> `local_multi_pack_index_one`. This definitions relies on the

Nit: s/definitions/definition

Show 7 quoted lines

> `the_hash_algo` global variable. Inline this and remove the global
> variable usage.
> 
> With this, remove `USE_THE_REPOSITORY_VARIABLE` usage from `midx.c`.
> 
> Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
> ---

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.