Re: [PATCH v2 02/10] midx-write: pass down repository to static functions

From: Christian Couder <christian.couder@gmail.com>
Date: Nov 20, 2024, 18:15 UTC
Message-ID: <CAP8UFD0RpTXCdeYPA44yiS1E-LsmSHVrGxNKaUFkvUqq+zNTZw@mail.gmail.com>
In-Reply-To: <20241119-374-refactor-midx-c-and-midx-write-c-to-not-depend-on-global-state-v2-2-e2f607174efc@gmail.com>

On Tue, Nov 19, 2024 at 5:36 PM Karthik Nayak <karthik.188@gmail.com> wrote:

Show 10 quoted lines

>
> In 'midx-write.c' there are a lot of static functions which use global
> variables `the_repository` or `the_hash_algo`. In a follow up commit,
> the repository variable will be added to `write_midx_context`, which
> some of the functions can use. But for functions which do not have
> access to this struct, pass down the required information from
> non-static functions `write_midx_file` and `write_midx_file_only`.
>
> This ensures that the usage of global variables is limited to these
> non-static functions, which will be cleaned up in a follow up commits.

s/commits/commit/

There are a few places in the patch where hash_to_hex() is replaced with hash_to_hex_algop(). However hash_to_hex() is not quite a static function and is not defined in 'midx-write.c'. So you might want to mention this additional change in the commit message.

Thanks.