RE: [PATCH v2 03/10] midx-write: use `revs->repo` inside `read_refs_snapshot`

From: Richard Kerry <richard.kerry@eviden.com>
Date: Nov 20, 2024, 14:26 UTC
Message-ID: <PA4PR07MB74069403837F36FD07D075EB9E212@PA4PR07MB7406.eurprd07.prod.outlook.com>
In-Reply-To: <Zz3dAZGAG3BupQqE@ArchLinux>

>> The `read_refs_snapshot` uses the `parse_oid_hex` function which 
>> internally uses global variables. Let's instead use
>
>Nit: s/variables/variable

No, that's fine. It's plural, so ends with 's'. Unless it should be "uses a global variable"

Show 5 quoted lines

>>
>> Also, while here, fix a missing newline after the functions definition.
>>
>
>Nit: s/functions/function

Maybe. But it could be "the function's definition" as it could be seen as possessive.

Regards, Richard.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.