Re: [PATCH v3 0/8] Change midx.c and midx-write.c to not use global variables

From: Patrick Steinhardt <ps@pks.im>
Date: Dec 3, 2024, 09:43 UTC
Message-ID: <Z07SsWL6sExkYUdi@pks.im>
In-Reply-To: <xmqq5xo8qh9h.fsf@gitster.g>

On Thu, Nov 28, 2024 at 10:27:54AM +0900, Junio C Hamano wrote:

Show 13 quoted lines

> Karthik Nayak <karthik.188@gmail.com> writes:
> 
> > Changes in v3:
> > - Split out the first commit into a separate series [1].
> > - Improved some of the commit messages to be more descriptive.
> > - Merged the 8th and 9th commits together, since they were similar.
> > - v2: https://lore.kernel.org/r/20241119-374-refactor-midx-c-and-midx-write-c-to-not-depend-on-global-state-v2-0-e2f607174efc@gmail.com
> 
> Merging either v2 or v3 to 'master', together with their
> prerequisite topics/patches, seems to result in identical trees,
> which is fine if reviews on previous rounds did not find any bugs.
> 
> Will queue.  Thanks.

I've had another read through the series and couldn't find any issues with it. I also scanned through v2 to see whether there was any feedback on code, but it seems like the only complaints there were about commit messages. So I guess it is expected that the trees are identical.

So this looks good to me overall, thanks!

Patrick