Re: [PATCH] Add a new lstat and fstat implementation based on Win32 API

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sep 5, 2007, 10:15 UTC
Message-ID: <Pine.LNX.4.64.0709051114340.28586@racer.site>
In-Reply-To: <46DE4B2E.70105@trolltech.com>

Hi,

On Wed, 5 Sep 2007, Marius Storm-Olsen wrote:

Show 20 quoted lines

> Rutger Nijlunsing said the following on 04.09.2007 23:02:
> > On Tue, Sep 04, 2007 at 01:57:38PM +0100, Johannes Schindelin wrote:
> > > Now I am utterly confused.  MSDN says
> > > 	FILETIME
> > > 	Contains a 64-bit value representing the number of 100-nanosecond
> > > intervals since January 1, 1601 (UTC).
> > > Hmm.
> > 
> > [Warning: war stories ahead...]
> > If you really, really want to know more:
> > http://search.cpan.org/~shay/Win32-UTCFileTime-1.45/lib/Win32/UTCFileTime.pm
> 
> Thanks, seems like it's the right decision then to ensure that we use UTC
> throughout Git on Windows
> 
> Hannes & Dscho, looks like we should revert 
> http://repo.or.cz/w/git/mingw/4msysgit.git?a=commitdiff;h=683775c00d9fb95bcbe4632f95b67a96b902fa59 
> then, and rather apply Dscho's patch for a custom time() implementation. 
> Dscho, was the custom implementation of time() enough to fix the issues 
> for you?

Umm. I am helplessly overloaded with non-Git work, and just made sure that it compiles ;-) Besides, I did not really understand what I was doing; just copying your code to convert from FILETIME to time_t.

Sorry, Dscho