Re: [PATCH] Add a new lstat and fstat implementation based on Win32 API

From: Johannes Sixt <j.sixt@eudaptics.com>
Date: Sep 4, 2007, 11:28 UTC
Message-ID: <46DD4159.9060406@eudaptics.com>
In-Reply-To: <46DD3FC9.2020706@trolltech.com>

Marius Storm-Olsen schrieb:

Show 10 quoted lines

> Johannes Sixt said the following on 04.09.2007 12:53:
>> Marius Storm-Olsen schrieb:
>>> Johannes Sixt said the following on 04.09.2007 09:41:
>>> http://repo.or.cz/w/git/mingw/4msysgit.git?a=commitdiff;h=f15974add93bdfa92775c77c00e7c65aefd42127 
>>
>>
>> Looks good, although you should now handle INVALID_HANDLE_VALUE at the 
>> beginning of git_fstat() like this:
> 
> Actually, that's already handled.

It's not a big deal: It's an unlikely code path, actually an indication of a coding error, so you can leave your version.

Show 6 quoted lines

>> Ok, I just tested FileTimeToLocalFileTime() in a tight loop, and I can 
>> run it 100,000,000 times per second. So I'm confident that there won't 
>> be any noticable degradation with my proposed change.
> 
> Ok. I haven't done the performance test with Git yet, but we'll see. If 
> it's not noticeable, I'll add it to all the timestamps we have.

Ack.

-- Hannes