Re: [PATCH] Add a new lstat and fstat implementation based on Win32 API

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sep 4, 2007, 14:48 UTC
Message-ID: <Pine.LNX.4.64.0709041547240.28586@racer.site>
In-Reply-To: <46DD6F2B.3060001@trolltech.com>

Hi,

On Tue, 4 Sep 2007, Marius Storm-Olsen wrote:

Show 19 quoted lines

> Johannes Schindelin wrote:
> > On Tue, 4 Sep 2007, Marius Storm-Olsen wrote:
> >> Neat, with the custom stat() changes cherry-picked on top of
> >> 4msysgit.git 'devel' branch, I only have one failing testcase 
> >> t6024-recursive-merge.sh when running $ NO_SYMLINKS=1 make -k
> >> 
> >> The rest are passing with flying colors!
> > 
> > Bad news.  I do not know if it was the newest version I tried, but I
> > could no longer fetch... said something about some bad file.
> 
> Then you're missing this patch:
> http://repo.or.cz/w/git/mingw/4msysgit.git?a=commitdiff;h=f15974add93bdfa92775c77c00e7c65aefd42127
> 
> I guess the quickest way is to manually apply this patch and recompile.
> (or add the '#undef fstat', and have git_fstat just 'return fstat(fd, buf)')
> 
> The problem is that without this patch fstat(0, buf) would fail with bad
> filedescriptor instead of returning the st_mode = S_IFIFO.

I guessed as much, but could not fetch the patch, since fetch was broken ;-)

For some utterly strange reason, "git fetch" accessed "git-fetch" in the cwd, not in /bin/... Funny.

Ciao, Dscho