Re: [PATCH] Add a new lstat implementation based on Win32 API, and make stat use that implementation too.
- From
- Reece Dunn <msclrhd@googlemail.com>
- Date
- Sep 2, 2007, 16:53 UTC
- Message-ID
- <3f4fd2640709020953k2f5367a0o64870da9d8e04f68@mail.gmail.com>
- In-Reply-To
- <F0525923-6D9B-46AA-9678-8B1263C45FF7@silverinsanity.com>
On 02/09/07, Brian Gernhardt <benji@silverinsanity.com> wrote:
Show 20 quoted lines
> > On Sep 2, 2007, at 12:33 PM, Reece Dunn wrote: > > > You pull a repository that contains executable scripts that are > > required to work in order to build the system. You then make some > > modifications to the local repository and run the 'git add .' command. > > Since this patch is reporting executable bits differently, the mode > > change is stored as well as the local modifications. Now the changes > > are pushed upstream (along with the file mode changes). > > > > Someone running a Linux machine, pulls your changes. When those files > > are checked out, the executable state of those scripts has now > > changed, preventing the Linux user from running those scripts. _That_ > > is what I meant. Or am I misunderstanding how git works in this case? > > This is what "git config core.fileMode false" is for. See git- > config's man page for information (or Documentation/config.txt). > > We already have a way to tell git that the "executable bit" is > worthless, and any Windows port should use it.
Ok, so as the executable bit is worthless, there doesn't need to be any special casing in this patch to deal with it.
- Reece