Re: [PATCH] Add a new lstat implementation based on Win32 API, and make stat use that implementation too.
On Sunday 02 September 2007 20:44, Marius Storm-Olsen wrote:
Show 8 quoted lines
> Johannes Sixt wrote:
> > I'm slightly negative about this. For a native Windows project the
> > executable bit does not matter, and for a cross-platform project this
> > check is not sufficient, but can even become annoying (think of a file
> > named 'www.google.com'). So we can just as well spare the few cycles.
>
> Ok, that's fine by me. It was only added for completeness, and with no
> benefits I'd say we drop it too.
I'll amend the patch accordingly.
Show 8 quoted lines
> >> return 0;
> >> + }
> >> + errno = ENOENT;
> >
> > Of course we need a bit more detailed error conditions, most importantly
> > EACCES should be distinguished.
>
> Right, you want to do that in a second commit?
Yes, please. Please don't forget to take care of the trailing-slash annoyance.
-- Hannes
Johannes Sixt <johannes.sixt@telecom.at>