Re: [PATCH] Add a new lstat and fstat implementation based on Win32 API
- From
David Kastrup <dak@gnu.org>
- Date
- Sep 4, 2007, 08:53 UTC
- Message-ID
- <86tzqag6bw.fsf@lola.quinscape.zz>
- In-Reply-To
- <46DD0C16.70101@eudaptics.com>
Johannes Sixt <j.sixt@eudaptics.com> writes:
Show 18 quoted lines
> Marius Storm-Olsen schrieb: >> Johannes Schindelin wrote: >>> To make it easier on others, I just uploaded it into the "teststat" >>> branch on 4msysgit.git (subject to removal in a few days). >> >> Ok, I've updated the patch in the 4msysgit.git repo, 'teststat' branch. >> RFC, and please test. > > Thanks a lot! I've pushed it out in mingw.git's master. > > The reason that t4200-rerere.sh fails is that we now store UTC in > st_mtime. However, for the garbage-collection we compare this entry > to a local time stamp. Therefore, I've pushed out a fixup patch at > the top of mingw.git's devel branch that converts mtime to local > time > (http://repo.or.cz/w/git/mingw.git?a=commitdiff;h=1b62ecb31068af06c2fa7664f06c6c36316aac2c). Would > you kindly conduct the performance test with this patch? I'm afraid > that this makes us substantially slower.
Wouldn't it make more sense to convert local time to mtime? That's one conversion per second at most rather than one conversion per file.
-- David Kastrup