Re: [PATCH] Add a new lstat and fstat implementation based on Win32 API

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sep 4, 2007, 10:48 UTC
Message-ID: <Pine.LNX.4.64.0709041145230.28586@racer.site>
In-Reply-To: <46DD0C16.70101@eudaptics.com>

Hi,

On Tue, 4 Sep 2007, Johannes Sixt wrote:

Show 13 quoted lines

> Marius Storm-Olsen schrieb:
> > Johannes Schindelin wrote:
> > > To make it easier on others, I just uploaded it into the "teststat"
> > > branch on 4msysgit.git (subject to removal in a few days).
> > 
> > Ok, I've updated the patch in the 4msysgit.git repo, 'teststat' branch.
> > RFC, and please test.
> 
> Thanks a lot! I've pushed it out in mingw.git's master.
> 
> The reason that t4200-rerere.sh fails is that we now store UTC in st_mtime.
> However, for the garbage-collection we compare this entry to a local time
> stamp.

Thanks for the explanation.

> Therefore, I've pushed out a fixup patch at the top of mingw.git's devel 
> branch that converts mtime to local time

On Linux, we compare to UTC to begin with, right? We should do that here, too... So if time(NULL) does not return UTC on MinGW, we have to wrap that function, too.

Ciao, Dscho