Re: [PATCH] Add a new lstat and fstat implementation based on Win32 API

From: Johannes Sixt <j.sixt@eudaptics.com>
Date: Sep 6, 2007, 16:18 UTC
Message-ID: <46E0285E.1000603@eudaptics.com>
In-Reply-To: <46DD0C16.70101@eudaptics.com>

Johannes Sixt schrieb:

Show 13 quoted lines

> Marius Storm-Olsen schrieb:
>> Johannes Schindelin wrote:
>>> To make it easier on others, I just uploaded it into the "teststat"
>>> branch on 4msysgit.git (subject to removal in a few days).
>>
>> Ok, I've updated the patch in the 4msysgit.git repo, 'teststat' branch.
>> RFC, and please test.
> 
> Thanks a lot! I've pushed it out in mingw.git's master.
> 
> The reason that t4200-rerere.sh fails is that we now store UTC in 
> st_mtime. However, for the garbage-collection we compare this entry to a 
> local time stamp.

This analysis is incorrect, I think. The reason we fail seems to be that t4200 uses test-chmtime, which uses utime(). Likely, we need a wrapper for that one?

-- Hannes