From: Usman Akinyemi <usmanakinyemi202@gmail.com>
Date: Wed, 08 Jan 2025 13:06:52 GMT
Subject: Re: [PATCH 2/4] version: refactor get_uname_info()
Message-ID: <CAPSxiM_Cc+Si1Qoygn7me9jAqfV+B-s3p1uP6=qApnk-Q4X+wA@mail.gmail.com>
In-Reply-To: <xmqqv7usylll.fsf@gitster.g>

Hi Junio

On Mon, Jan 6, 2025 at 9:34 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Usman Akinyemi <usmanakinyemi202@gmail.com> writes:
>
> > Some code from "builtin/bugreport.c" uses uname(2) to get system
> > information.
> >
> > Let's refactor this code into a new get_uname_info() function, so
> > that we can reuse it in a following commit.
>
> This does two things: refactor and enhancement.  Shouldn't it do
> pure refactoring in a single patch, with a follow-up patch that
> extends it to allow the caller to hide the system details?
>
Thanks for this, I will split the commit into two patches in the next iteration.