From: Pablo Date: Mon, 16 Mar 2026 19:48:25 GMT Subject: Re: [GSoC RFC PATCH] graph: add --graph-max option to limit displayed columns Message-ID: In-Reply-To: Thanks for the feedback, > Do you think '--graph-max' signifies that we're talking about the > maximum columns to display? Yeah, doesn't seem clear enough, but --graph-col-limit seems too verbose. What do you think about --graph-max-cols ? It's just one char less but I feel it is more readable. > One question to ask is, is this even needed anymore and does it really > make sense to add it? > The TODO was added back in 2008, that's ~16 years ago and was not > touched till now. So perhaps no one needs it? If so, maybe the smarter > option is to simply remove the TODO? > Or do you see a usecase where this is useful? If so, it would be nice to > talk about that in the commit message. I've run 'git log --graph --all' on the Git repo itself on 'next' and just scrolling a bit down up to March 5 there are already +35 branches, which isn't very readable. It's been 16 years but I believe that is still a good thing to add, even if a lot of graph viewing happens with third parties, adding this makes Git a bit more self sufficient. This is even more useful in a case where the third party is not an option. That said, if this still doesn't seem useful I would remove the TODO to avoid further confusion in the future. > My preference would be not to have implicit behavior but also at the > same time guide the user in the right path, so: > $ git log --graph-max=4 > fatal: --graph-max used without --graph Ok, will add this to v2. > Trying it out: > ... > So we still keep the spaces, but only remove the column indicator Padding needs to be adjusted to the columns truncated. Will add it to v2. > Isn't this more of `graphs_needs_truncation()`? Yes, I'll rename it in v2. > Shouldn't we allow users to set 0? That combined with an unsigned int > would: > 1. remove the need for MINIMUM_GRAPH_COLUMNS > 2. allow users to specify that they do not want a column limit I think it's better not to let 0 be a good input, it's the same as not using it making it redundant. Is set to 0 by default from the memset(). Other "max" options I've tried that allow 0, don't share the "no limit" behaviour. git log --graph --all --max-parents=0 git log --max-count=0 That's why I wouldn't let it be valid. The unsigned int is better for clarity. > I think overall a little more explanation in the commit message makes it > easier to understand the context and also helps reviewers! > > Shouldn't we also talk about the todo and the commit (c12172d2ea (Add > history graph API, 2008-05-04)) in which it was added? > The first sentence seems to talk about the option like it already > exists, when the second para introduces it. It would be nice if the > first para explained the problem we're trying to solve and why and the > second para then dove into the solution space. My bad, I'll improve the commit msg on v2 to be more clear about the problem, what it does and where it comes from. > What does this mean? Validate how? It validated user input to avoid them to set 0. In case of letting them set 0 (no limit) this would be removed. I'll wait for the decision about whether this TODO from 2008 is worth doing before a v2. Thanks, Pablo