Re: [PATCH 2/2] git-svn, perl/Git.pm: extend and use Git->prompt method for querying users

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 3, 2012, 18:19 UTC
Message-ID: <7vzke4vebl.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4F00B7F3.1060105@tu-clausthal.de>

Sven Strickroth <sven.strickroth@tu-clausthal.de> writes:

> I'm still for the second patch to be applied (maybe w/o the certificate
> filename prompt), too, because this makes git-svn behave the save way as
> git-core does (especially asking for username).

I do not have much issues against the patch if the filename thing is excluded as a short-term workaround to avoid regression.

For people who have been used to interact with git-svn from the terminal but has *_ASKPASS for reasons other than their use of git-svn in their environment, the change to the username codepath is technically a regression, as they used to be able to see and correct typo while giving their username but with the patch *_ASKPASS will kick in and they have to type in bline, but I am not particularly worried about it. It is something you type very often and committed to your muscle memory anyway.