Re: [PATCH 2/2] git-svn, perl/Git.pm: extend and use Git->prompt method for querying users

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 4, 2012, 00:12 UTC
Message-ID: <7vy5toqqab.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4F038E49.9080809@tu-clausthal.de>

Sven Strickroth <sven.strickroth@tu-clausthal.de> writes:

Show 10 quoted lines

> git-svn reads usernames and other user queries from an interactive
> terminal. This cause GUIs (w/o STDIN connected) to hang waiting forever
> for git-svn to complete (http://code.google.com/p/tortoisegit/issues/detail?id=967).
> git-core already asks for username using *_ASKPASS tools, this commit
> also enables git-svn to do so.
>
> This change extends the Git::prompt method, so that it can also be used
> for non password queries (e.g. usernames), and makes use of it instead
> of using hand-rolled prompt-response code that only works with the
> interactive terminal.

Now "prompt" is no longer a method but is merely a helper function, so I've queued this (and 1/2 rewrite we discussed in a separate thread) to 'pu' after rewording the commit log message.

Thanks.