git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] git-svn, perl/Git.pm: extend and use Git->prompt method for querying users

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 28, 2011, 21:00 UTC
Message-ID
<7v39c41keo.fsf@alter.siamese.dyndns.org>
In-Reply-To
<4EFAF241.9050806@tu-clausthal.de>
Sven Strickroth <sven.strickroth@tu-clausthal.de> writes:
Show 7 quoted lines
> Am 28.12.2011 03:41 schrieb Junio C Hamano:
>> I am afraid the extra "Certificate unknown. " prefix may make the prompt
>> way too long to fit on a line on the terminal or in the GUI. Would it be
>> Ok to perhaps add LF to make it a multi-line prompt? Do GUI based helpers
>> make that into a dialog box with multi-line prompt, or do they just barf?
>
> LF is problematic. But we could do $prompt =~ s/\n/ /g; in _prompt()-method.

I actually was hoping that the answer is "it depends on the helper specified by *_ASKPASS".

In any case, let's not add that extra "Certificate unknown. " prefix at all to avoid regressions and queue this patch series for real.

After somebody comes up with a way to deal with overlong prompt, building on top of this series, we can work on making this particular prompt longer and more descriptive.

Previous: Sven StrickrothNext: Junio C Hamano
Message 49 of 82 in “honour GIT_ASKPASS for querying username in git-svn”
  1. honour GIT_ASKPASS for querying username in git-svnSven Strickroth, Nov 17, 2011
  2. Erik Faye-LundNov 18, 2011
  3. Sven StrickrothNov 18, 2011
  4. Erik Faye-LundNov 18, 2011
  5. Sven StrickrothNov 26, 2011
  6. Jeff KingNov 30, 2011
  7. Sven StrickrothDec 26, 2011
  8. Jakub NarebskiDec 27, 2011
  9. Sven StrickrothDec 27, 2011
  10. Jakub NarebskiDec 27, 2011
  11. 0/5 honour *_ASKPASS for querying user in git-svnSven Strickroth, Dec 27, 2011
  12. 1/5 add central method for prompting a user using GIT_ASKPASS or SSH_ASKPASSSven Strickroth, Dec 27, 2011
  13. Junio C HamanoDec 27, 2011
  14. Thomas AdamDec 27, 2011
  15. Junio C HamanoDec 27, 2011
  16. 2/5 switch to central prompt methodSven Strickroth, Dec 27, 2011
  17. Junio C HamanoDec 27, 2011
  18. 3/5 honour *_ASKPASS for querying username and for querying further actions like unknown certificatesSven Strickroth, Dec 27, 2011
  19. Junio C HamanoDec 27, 2011
  20. 4/5 ignore empty *_ASKPASS variablesSven Strickroth, Dec 27, 2011
  21. Junio C HamanoDec 27, 2011
  22. 5/5 make askpass_prompt a global prompt method for asking usersSven Strickroth, Dec 27, 2011
  23. Junio C HamanoDec 27, 2011
  24. Junio C HamanoDec 27, 2011
  25. 1/2 git-svn, perl/Git.pm: add central method for prompting passwords honoring GIT_ASKPASS and SSH_ASKPASSSven Strickroth, Dec 28, 2011
  26. Junio C HamanoDec 28, 2011
  27. Sven StrickrothDec 28, 2011
  28. Jakub NarebskiDec 28, 2011
  29. Ævar Arnfjörð BjarmasonJan 3, 2012
  30. Sven StrickrothJan 3, 2012
  31. Ævar Arnfjörð BjarmasonJan 3, 2012
  32. Ævar Arnfjörð BjarmasonJan 3, 2012
  33. Sven StrickrothJan 3, 2012
  34. Junio C HamanoJan 3, 2012
  35. Junio C HamanoJan 3, 2012
  36. Sven StrickrothJan 3, 2012
  37. Junio C HamanoJan 4, 2012
  38. Sven StrickrothJan 4, 2012
  39. Sven StrickrothJan 4, 2012
  40. Jeff KingJan 4, 2012
  41. Sven StrickrothJan 4, 2012
  42. Junio C HamanoJan 4, 2012
  43. Sven StrickrothJan 7, 2012
  44. Junio C HamanoJan 4, 2012
  45. Sven StrickrothJan 4, 2012
  46. 2/2 git-svn, perl/Git.pm: extend and use Git->prompt method for querying usersSven Strickroth, Dec 28, 2011
  47. Junio C HamanoDec 28, 2011
  48. Sven StrickrothDec 28, 2011
  49. Junio C HamanoDec 28, 2011
  50. Junio C HamanoDec 28, 2011
  51. Sven StrickrothDec 28, 2011
  52. Junio C HamanoDec 28, 2011
  53. Sven StrickrothDec 30, 2011
  54. Jeff KingDec 30, 2011
  55. Sven StrickrothDec 30, 2011
  56. Junio C HamanoJan 1, 2012
  57. Sven StrickrothJan 1, 2012
  58. Sven StrickrothJan 1, 2012
  59. Sven StrickrothJan 1, 2012
  60. Junio C HamanoJan 3, 2012
  61. Jeff KingJan 3, 2012
  62. Sven StrickrothFeb 12, 2012
  63. Jakub NarebskiFeb 12, 2012
  64. Sven StrickrothFeb 12, 2012
  65. Jeff KingFeb 14, 2012
  66. Junio C HamanoFeb 14, 2012
  67. Jeff KingFeb 14, 2012
  68. Sven StrickrothJan 3, 2012
  69. Junio C HamanoJan 4, 2012
  70. Sven StrickrothOct 6, 2012
  71. Junio C HamanoOct 6, 2012
  72. 0/2 second trySven Strickroth, Nov 11, 2012
  73. Sven StrickrothNov 24, 2012
  74. Junio C HamanoNov 26, 2012
  75. Sven StrickrothDec 17, 2012
  76. Junio C HamanoDec 17, 2012
  77. 1/3 git-svn, perl/Git.pm: add central method for prompting passwordsSven Strickroth, Dec 18, 2012
  78. 2/3 perl/Git.pm: Honor SSH_ASKPASS as fallback if GIT_ASKPASS is not setSven Strickroth, Dec 18, 2012
  79. Jeff KingDec 18, 2012
  80. 3/3 git-svn, perl/Git.pm: extend and use Git->prompt method for querying usersSven Strickroth, Dec 18, 2012
  81. 1/2 git-svn, perl/Git.pm: add central method for prompting passwords honoring GIT_ASKPASS and SSH_ASKPASSSven Strickroth, Nov 11, 2012
  82. 2/2 git-svn, perl/Git.pm: extend and use Git->prompt method for querying usersSven Strickroth, Nov 11, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.