Re: [PATCH 2/2] git-svn, perl/Git.pm: extend and use Git->prompt method for querying users

From: Jeff King <peff@peff.net>
Date: Feb 14, 2012, 22:20 UTC
Message-ID: <20120214222055.GE24802@sigill.intra.peff.net>
In-Reply-To: <4F37E843.6070107@tu-clausthal.de>

On Sun, Feb 12, 2012 at 05:26:43PM +0100, Sven Strickroth wrote:

Show 6 quoted lines

> Am 12.02.2012 17:11 schrieb Jakub Narebski:
> > Doesn't Subversion use SSH directly?  If it is so, the question is
> > about how SSH itself supports SSH_ASKPASS.
> 
> Oh sorry, I mixed up SSH and SVN_ASKPASS. :( Of couse SSH_ASKPASS is
> provided by the ssh-client itself.

That raises an interesting point for git (I don't remember seeing this in the previous discussion, so apologies if I'm repeating). We sometimes use SSH_ASKPASS for internal prompting, and sometimes via calling out to ssh. So forgetting about git being consistent with the rest of the world for a moment, I think we are inconsistent with ourselves. E.g.:

  export SSH_ASKPASS=whatever

  # this will try the terminal first, then SSH_ASKPASS, because it is
  # ssh doing the asking
  git push ssh://example.com/repo.git

  # this will try SSH_ASKPASS first, then the terminal, because git is
  # doing the asking
  git push https://example.com/repo.git

So now I'm more convinced than ever that the order should be GIT_ASKPASS, terminal, SSH_ASKPASS.

-Peff