Re: [PATCH 1/2] git-svn, perl/Git.pm: add central method for prompting passwords honoring GIT_ASKPASS and SSH_ASKPASS
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 4, 2012, 18:58 UTC
- Message-ID
- <7vmxa3pa6e.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <4F0405D4.9090102@tu-clausthal.de>
Sven Strickroth <sven.strickroth@tu-clausthal.de> writes:
> Some perl versions, like the one from msys, crash sometimes > if reading from STDIN wasn't successful and chomp is applied > to the variable into which was read.
Depending on how widespread such implementations of Perl are, a patch to fix other uses of chomps might deserve to be on the maintenance track independent from this patch series. I seem to find many hits to:
$ git grep -e 'chomp *([^)@]*='
already in our codebase.