Re: [PATCH 0/2] second try

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 17, 2012, 20:08 UTC
Message-ID: <7vehiol9w2.fsf@alter.siamese.dyndns.org>
In-Reply-To: <50CF4020.4090901@tu-clausthal.de>

Sven Strickroth <sven.strickroth@tu-clausthal.de> writes:

Show 8 quoted lines

> Am 26.11.2012 05:50 schrieb Junio C Hamano:
>> I think between Peff and me it fell in the cracks during the
>> hand-off; I do not know about the others, probably people did not
>> find it interesting perhaps?
>> 
>> I'll add Eric Wong (git-svn submaintainer) to Cc.
>
> I received no feedback, so is there any progress on this issue?

I took a look at it, and from the code-cleanness point of view, I think it loos more or less right, even though I'd prefer to see the "fall back on SSH_ASKPASS" bit as a separate patch, either before or after [1/2] that moves the logic to a separate helper function.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.