Re: [PATCH 1/2] git-svn, perl/Git.pm: add central method for prompting passwords honoring GIT_ASKPASS and SSH_ASKPASS
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 4, 2012, 00:10 UTC
- Message-ID
- <7v39bws4xi.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <4F038EC8.505@tu-clausthal.de>
Sven Strickroth <sven.strickroth@tu-clausthal.de> writes:
Show 7 quoted lines
> Am 03.01.2012 23:51 schrieb Junio C Hamano: >> Sven, does it look agreeable? And more importantly, does it still work? ;-) > > Works for me :) > > I also updated my second patch minutes ago to fit onto the new patch > (w/o the filename stuff).
Thanks.
For the second patch, I have a feeling that Peff's earlier suggestion to give precedence to the terminal interaction over SSH_ASKPASS iff we can open terminal, but I think the first one is OK for 1.7.9.
I'll queue both of them in 'pu' for now just in case others spot silly mistakes I made while rewriting the first one, though.