Re: [PATCH 2/3] perl/Git.pm: Honor SSH_ASKPASS as fallback if GIT_ASKPASS is not set

From: Jeff King <peff@peff.net>
Date: Dec 18, 2012, 00:57 UTC
Message-ID: <20121218005725.GA4125@sigill.intra.peff.net>
In-Reply-To: <50CFB8BF.4000405@tu-clausthal.de>

On Tue, Dec 18, 2012 at 01:28:47AM +0100, Sven Strickroth wrote:

Show 5 quoted lines

> If GIT_ASKPASS environment variable is not set, git-svn does not try to use
> SSH_ASKPASS as git-core does. This change adds a fallback to SSH_ASKPASS.
> 
> Signed-off-by: Sven Strickroth <email@cs-ware.de>
> ---

Thanks, this series looks fine to me.

I skimmed through the original thread. It looks like we got bogged down in discussion of whether GIT_ASKPASS should fall back on error, and whether SSH_ASKPASS should come _after_ the terminal has been tried and failed. This version of the series brings the behavior of git-svn in line with the rest of git, which I think is a good first step.

I don't know whether we want to take a second step and tweak the order in both perl and C code. Since nobody has mentioned it in the interim months, I'm assuming it's not a big deal, and people are happy enough with the current ordering. So unless somebody feels strongly about it, it's not worth bothering.

-Peff