Re: [PATCH 2/3] t3404: use configured shell instead of /bin/sh

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 24, 2008, 00:03 UTC
Message-ID: <7vfxvjxlsv.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080223231253.GA14320@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 18 quoted lines

> On Sat, Feb 23, 2008 at 02:55:42PM -0800, Junio C Hamano wrote:
>
>> I think the basic goal should be to come up with a way to make
>> sure that "cd t/ && make" and "cd t/ && sh -x tXXXX-name.sh"
>> would get an environment as close as possible to what happens
>> when you run "make test" at the toplevel.
>
> I was thinking of something like this:
> ...
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index 83889c4..3c4e21f 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -342,6 +342,8 @@ if ! test -x ../test-chmtime; then
>  	exit 1
>  fi
>  
> +. ../GIT-BUILD-OPTIONS

Sounds sane to me.