git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/3] t3404: use configured shell instead of /bin/sh

From
Jeff King <peff@peff.net>
Date
Feb 21, 2008, 00:00 UTC
Message-ID
<20080221000044.GB6429@coredump.intra.peff.net>
In-Reply-To
<20080220235944.GA6278@coredump.intra.peff.net>

The fake-editor shell script invoked /bin/sh; normally this is fine, unless the /bin/sh doesn't meet our compatibility requirements, as is the case with Solaris. Specifically, the $() syntax used by fake-editor is not understood.

Signed-off-by: Jeff King <peff@peff.net>
---
 t/t3404-rebase-interactive.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh
index e5ed745..62e65d7 100755
--- a/t/t3404-rebase-interactive.sh
+++ b/t/t3404-rebase-interactive.sh
@@ -61,8 +61,8 @@ test_expect_success 'setup' '
 	git tag I
 '
 
-cat > fake-editor.sh <<\EOF
-#!/bin/sh
+echo "#!$SHELL" >fake-editor
+cat >> fake-editor.sh <<\EOF
 case "$1" in
 */COMMIT_EDITMSG)
 	test -z "$FAKE_COMMIT_MESSAGE" || echo "$FAKE_COMMIT_MESSAGE" > "$1"
-- 
1.5.4.2.247.g107bd
Previous: Jeff KingNext: Johannes Sixt
Message 3 of 28 in “solaris test results”
  1. 0/3 solaris test resultsJeff King, Feb 20, 2008
  2. 1/3 git_config_*: don't assume we are parsing a config fileJeff King, Feb 21, 2008
  3. 2/3 t3404: use configured shell instead of /bin/shJeff King, Feb 21, 2008
  4. Johannes SixtFeb 23, 2008
  5. Junio C HamanoFeb 23, 2008
  6. Junio C HamanoFeb 23, 2008
  7. Johannes SixtFeb 23, 2008
  8. Jeff KingFeb 23, 2008
  9. Junio C HamanoFeb 23, 2008
  10. Jeff KingFeb 23, 2008
  11. Junio C HamanoFeb 23, 2008
  12. Jeff KingFeb 23, 2008
  13. Junio C HamanoFeb 23, 2008
  14. Jeff KingFeb 23, 2008
  15. Junio C HamanoFeb 24, 2008
  16. Jeff KingFeb 24, 2008
  17. Jeff KingFeb 23, 2008
  18. Junio C HamanoFeb 23, 2008
  19. Jeff KingFeb 23, 2008
  20. Jeff KingFeb 23, 2008
  21. Junio C HamanoFeb 23, 2008
  22. Jeff KingFeb 23, 2008
  23. 3/3 diff: fix java funcname pattern for solarisJeff King, Feb 21, 2008
  24. Junio C HamanoFeb 21, 2008
  25. Jeff KingFeb 21, 2008
  26. Junio C HamanoFeb 22, 2008
  27. Junio C HamanoFeb 22, 2008
  28. Jeff KingFeb 22, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.