Re: [PATCH 2/3] t3404: use configured shell instead of /bin/sh

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 23, 2008, 22:35 UTC
Message-ID: <7v4pbz1etm.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080223222837.GA13628@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 11 quoted lines

> On Sat, Feb 23, 2008 at 04:12:19PM -0500, Jeff King wrote:
>
>> > shell there.  If you used $SHELL not $SHELL_PATH and wrote to
>> > fake-editor.sh, you would have noticed that using $SHELL there
>> > was wrong as it would have said "#!bash" for you ;-)
>> 
>> Actually, my $SHELL is "/usr/local/bin/bash" on the box in question.
>
> Hmm. Actually, we just set SHELL_PATH to SHELL in the Makefile. So I
> really don't see the point of SHELL_PATH at all, unless there are some
> setups where it is already set outside of git.

Well, on one of my machines, I seem to be getting SHELL=bash (not /bin/bash).

Honestly, I do not think it matters getting the value from Makefile for this particular case, but I'd rather get people into habits to run "make tXXXX-name", not "sh ./tXXXX-name.sh", unless they know what they are doing.