Re: [PATCH 2/3] t3404: use configured shell instead of /bin/sh

From: Jeff King <peff@peff.net>
Date: Feb 23, 2008, 22:28 UTC
Message-ID: <20080223222837.GA13628@coredump.intra.peff.net>
In-Reply-To: <20080223211219.GA13178@coredump.intra.peff.net>

On Sat, Feb 23, 2008 at 04:12:19PM -0500, Jeff King wrote:

Show 5 quoted lines

> > shell there.  If you used $SHELL not $SHELL_PATH and wrote to
> > fake-editor.sh, you would have noticed that using $SHELL there
> > was wrong as it would have said "#!bash" for you ;-)
> 
> Actually, my $SHELL is "/usr/local/bin/bash" on the box in question.

Hmm. Actually, we just set SHELL_PATH to SHELL in the Makefile. So I really don't see the point of SHELL_PATH at all, unless there are some setups where it is already set outside of git.

-Peff