git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] solaris test results

From
Jeff King <peff@peff.net>
Date
Feb 22, 2008, 05:42 UTC
Message-ID
<20080222054229.GA32294@coredump.intra.peff.net>
In-Reply-To
<7vr6f5pnmz.fsf@gitster.siamese.dyndns.org>
On Thu, Feb 21, 2008 at 09:26:44PM -0800, Junio C Hamano wrote:
> Here is a possible solution.
> 
> This is a fairly mechanical substitution (grepping for "git diff -u"
> and "diff -u", and replacing them with test_compare_expect.

I think this approach is reasonable (though as I suggested in my original message, I probably would have selected something a little easier to type, like test_cmp).

> Test scripts can be run with --no-diff-u option, to use "git
> diff -u --no-index" for comparison instead.

I thought you were against using "git diff" in the test suite for this purpose. Using "diff -u" produces nice output in case of failure, but even "cmp" can do the job of returning an exit code. Perhaps it makes sense as a more robust fallback.

Perhaps the command line option should be --compare=cmp, which lets the caller choose an appropriate fallback for their system (and which means that you can use --compare="git diff" to make debugging more pleasant, but confirm with --compare="cmp" before claiming breakage on the list).

But honestly, I do not care that much about this. I don't even usually use Solaris; I happened to have access to a box, so I followed up on Whit's bug report. It is probably not worth spending a lot of time over-engineering a solution. I have no idea how common it is to run the test suite on boxes without GNU diff.

-Peff
Previous: Junio C Hamano
Message 28 of 28 in “solaris test results”
  1. 0/3 solaris test resultsJeff King, Feb 20, 2008
  2. 1/3 git_config_*: don't assume we are parsing a config fileJeff King, Feb 21, 2008
  3. 2/3 t3404: use configured shell instead of /bin/shJeff King, Feb 21, 2008
  4. Johannes SixtFeb 23, 2008
  5. Junio C HamanoFeb 23, 2008
  6. Junio C HamanoFeb 23, 2008
  7. Johannes SixtFeb 23, 2008
  8. Jeff KingFeb 23, 2008
  9. Junio C HamanoFeb 23, 2008
  10. Jeff KingFeb 23, 2008
  11. Junio C HamanoFeb 23, 2008
  12. Jeff KingFeb 23, 2008
  13. Junio C HamanoFeb 23, 2008
  14. Jeff KingFeb 23, 2008
  15. Junio C HamanoFeb 24, 2008
  16. Jeff KingFeb 24, 2008
  17. Jeff KingFeb 23, 2008
  18. Junio C HamanoFeb 23, 2008
  19. Jeff KingFeb 23, 2008
  20. Jeff KingFeb 23, 2008
  21. Junio C HamanoFeb 23, 2008
  22. Jeff KingFeb 23, 2008
  23. 3/3 diff: fix java funcname pattern for solarisJeff King, Feb 21, 2008
  24. Junio C HamanoFeb 21, 2008
  25. Jeff KingFeb 21, 2008
  26. Junio C HamanoFeb 22, 2008
  27. Junio C HamanoFeb 22, 2008
  28. Jeff KingFeb 22, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.