Re: [PATCH 2/3] t3404: use configured shell instead of /bin/sh

From: Jeff King <peff@peff.net>
Date: Feb 23, 2008, 22:49 UTC
Message-ID: <20080223224938.GA14231@coredump.intra.peff.net>
In-Reply-To: <7vve4fz3y1.fsf@gitster.siamese.dyndns.org>

On Sat, Feb 23, 2008 at 02:46:30PM -0800, Junio C Hamano wrote:

Show 10 quoted lines

> I think our messages are crossing, but (1) currently we do not
> export much from t/Makefile and the only people who can get
> affected are on platforms that do need custom configuration, and
> the difference being subtle and rare makes it more surprising
> and harder to diagnose when the difference does matter, (2) I'd
> like to place some stuff in t/Makefile in such a way that no
> tests that runs a server that listens to a network port is not
> run by default, among other things, which means the difference
> between "sh tXXXX-name.sh" and "make tXXXX-name" will get
> bigger not smaller.

OK, thanks for explaining (point 2 was what I was looking for). Personally, I think we are better off putting such configuration into a file that gets sourced by test-lib.sh, but I don't overly care. I _do_ find "sh -x tXXXX-name.sh" useful from time to time, but mainly only while debugging the test scripts themselves.

-Peff