Re: [PATCH 2/3] t3404: use configured shell instead of /bin/sh

From: Jeff King <peff@peff.net>
Date: Feb 23, 2008, 21:15 UTC
Message-ID: <20080223211536.GA13280@coredump.intra.peff.net>
In-Reply-To: <200802232209.41428.johannes.sixt@telecom.at>

On Sat, Feb 23, 2008 at 10:09:41PM +0100, Johannes Sixt wrote:

Show 13 quoted lines

> On Saturday 23 February 2008 21:34, Junio C Hamano wrote:
> > -echo "#!$SHELL" >fake-editor
> > +echo "#!$SHELL_PATH" >fake-editor.sh
> 
> Hm, when we run the test outside make, like
> 
>    $ sh t3404-rebase-interactive.sh
> 
> then the fake-editor.sh script begins with this line:
> 
>    #!
> 
> Isn't this a trap similar to what Jeff wanted to avoid?

Well, the trap I wanted to avoid is that "/bin/sh" specifically is broken. But yes, I think losing the ability to run the tests from the commandline is bad.

Ideally we figured out a sane shell for our shell scripts in the main build process, and we want to always use that here. I think "git rev-parse --sane-shell-path" is probably overkill. Maybe test-lib.sh can source a file of build-time options? The "diff -u" vs "cmp" thing could go there, as well.

-Peff