Re: [PATCH 2/3] t3404: use configured shell instead of /bin/sh
- From
Jeff King <peff@peff.net>
- Date
- Feb 23, 2008, 22:39 UTC
- Message-ID
- <20080223223933.GA13683@coredump.intra.peff.net>
- In-Reply-To
- <7vmypr1gmh.fsf@gitster.siamese.dyndns.org>
On Sat, Feb 23, 2008 at 01:56:38PM -0800, Junio C Hamano wrote:
Show 6 quoted lines
> > Well, the trap I wanted to avoid is that "/bin/sh" specifically is > > broken. But yes, I think losing the ability to run the tests from the > > commandline is bad. > > We never had it. "make t3404-rebase-interactive" is the way to > do so.
Well, that is a surprise to me, since I have been using it for almost two years with no problems. And I know I am not alone because others have posted snippets on the list invoking a test via "sh -x", including both Dscho and you.
Is there a good reason not to do so?
-Peff