git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/3] solaris test results

From
Jeff King <peff@peff.net>
Date
Feb 20, 2008, 23:59 UTC
Message-ID
<20080220235944.GA6278@coredump.intra.peff.net>

I have now run every test script <= t9001 using the current 'master' on the SunOS 5.8 box available to me. It _mostly_ passed. Following are three patches:

  1/3: git_config_*: don't assume we are parsing a config file
       This is an actual minor bug which was covered by most platforms'
       ability to print (null) for NULL. I posted this earlier, but with
       a typo.
  2/3: t3404: use configured shell instead of /bin/sh
       This is a problem purely in the test script, not git itself.
  3/3: diff: fix java funcname pattern for solaris
       This is a Solaris-specific bug in git.
With these fixes, everything passes for me with a few exceptions:
  - Sun's diff doesn't understand "-u". I was able to use GNU diff.
    Since comparing actual and expected output is so common, we could
    potentially abstract this with a "test_cmp()" function and use
    something platform specific. It's probably not worth the trouble, as
    it impacts only the test suite, and only on systems with a totally
    broken diff.
  - t4020 fails without gnu grep, as it requires "grep -a"
  - t4024 fails unless /usr/xpg4/bin is in your path, as the regular
    version of 'expr' is unhappy with us (I didn't investigate too
    closely)
  - t4118, t4200, t8001, and t8002 fail unless you have GNU sed. The
    xpg4 sed barfs if there's no newline at the end of input (and this
    is specifically part of these tests)
  - I couldn't personally run t5502, t5505, t5512, t5520, or t9001, all
    of which require the Git.pm module; the version of perl on this
    machine is old (5.005_02) and complained about the 'our' keyword
  - t7505 uses a hook which hard-codes /bin/sh but uses syntax that
    the Solaris /bin/sh doesn't like. Maybe hooks should get their
    $SHELL value replaced?
  - t3900 mostly passes, but fails to correctly convert between EUCJP
    and ISO-2022-JP (in either direction). I didn't investigate very
    far.
  - git-filter-branch invokes "sh" for the commit filter, which invokes
    the broken Solaris /bin/sh. This isn't wrong, exactly, but it might
    make more sense to invoke $SHELL.

Now I must go gouge out my eyes, so that I may never see the output of Solaris /bin/sh ever again.

-Peff
Next: Jeff King
Message 1 of 28 in “solaris test results”
  1. 0/3 solaris test resultsJeff King, Feb 20, 2008
  2. 1/3 git_config_*: don't assume we are parsing a config fileJeff King, Feb 21, 2008
  3. 2/3 t3404: use configured shell instead of /bin/shJeff King, Feb 21, 2008
  4. Johannes SixtFeb 23, 2008
  5. Junio C HamanoFeb 23, 2008
  6. Junio C HamanoFeb 23, 2008
  7. Johannes SixtFeb 23, 2008
  8. Jeff KingFeb 23, 2008
  9. Junio C HamanoFeb 23, 2008
  10. Jeff KingFeb 23, 2008
  11. Junio C HamanoFeb 23, 2008
  12. Jeff KingFeb 23, 2008
  13. Junio C HamanoFeb 23, 2008
  14. Jeff KingFeb 23, 2008
  15. Junio C HamanoFeb 24, 2008
  16. Jeff KingFeb 24, 2008
  17. Jeff KingFeb 23, 2008
  18. Junio C HamanoFeb 23, 2008
  19. Jeff KingFeb 23, 2008
  20. Jeff KingFeb 23, 2008
  21. Junio C HamanoFeb 23, 2008
  22. Jeff KingFeb 23, 2008
  23. 3/3 diff: fix java funcname pattern for solarisJeff King, Feb 21, 2008
  24. Junio C HamanoFeb 21, 2008
  25. Jeff KingFeb 21, 2008
  26. Junio C HamanoFeb 22, 2008
  27. Junio C HamanoFeb 22, 2008
  28. Jeff KingFeb 22, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.