From: Johannes Sixt Date: Wed, 25 Mar 2026 17:44:20 GMT Subject: Re: [GSoC PATCH v4 0/3] graph: add --graph-lane-limit option Message-ID: <251cbdd8-26ca-4569-9801-5eb278de7e0c@kdbg.org> In-Reply-To: Am 25.03.26 um 13:28 schrieb Pablo: > Johannes Sixt () writes: >> Let me suggest a different separation. > > I'll merge 1st and 2nd patch together into a single one, adding the option > together with the actual logic that does it. This fixes what SZEDER said about > the first patch alone breaking the build. > > And the documentation + tests on a separate commit. It is better to add documentation and tests in the same commit that add the feature, because both serve as a specification what the code is supposed to do. This way reviewers can decide whether the code does indeed work as designed. On top of that, when the code has to be inspected later, the commit that introduced the code shows immediately whether a certain behavior was intentional or not. So, you would end up with a single patch. But to make reviewing easier, I proposed a different split: >> 1. The first patch limits the graph width with a hard-coded limit, say >> 15 lanes. It limits the graph *always*. Choose a limit that is large >> enough to pass all tests. This change will touch the graphing engine, but almost nothing else. >> 2. The next patch adds --graph-lane-limit and its documentation. Let it >> do its thing. Revert to the default limit value 0, i.e., unlimited. This change now introduces all the plumbing that passes the user's option through to the engine. >> 3. Next, add additional eye-candy. I am alluding to the line that marks >> where a graph lane was truncated. If possible, this change provides final touches that can reasonably be left out from the first patch without compromising its basic functionality. >> (4. If more detailed document is warranted, e.g., an example chart, do >> this as a separate patch that can now show all bells and whistles that >> the earlier commits have implemented. Whether this makes sense as a >> separate step, or whether documentation grows with the earlier patches, >> is a judgement call.) This could be a new paragraph in the manuals with example charts if doing so makes sense. -- Hannes