From: Jonathan Tan <jonathantanmy@google.com>
Date: Thu, 10 Feb 2022 19:00:15 GMT
Subject: Re: [PATCH 2/8] submodule: store new submodule commits oid_array in a struct
Message-ID: <20220210190015.657085-1-jonathantanmy@google.com>
In-Reply-To: <20220210044152.78352-3-chooglen@google.com>

Glen Choo <chooglen@google.com> writes:
> +/*
> + * Holds relevant information for a changed submodule. Used as the .util
> + * member of the changed submodule string_list_item.
> + */
> +struct changed_submodule_data {
> +	/* The submodule commits that have changed in the rev walk. */
> +	struct oid_array *new_commits;
> +};

Overall this change is straightforward and looks good, except that I
think that the struct oid_array can be embedded directly instead of
through a pointer.