Re: [PATCH] config: fix several access(NULL) calls

From: Jeff King <peff@peff.net>
Date: Jul 13, 2012, 13:00 UTC
Message-ID: <20120713130021.GA2553@sigill.intra.peff.net>
In-Reply-To: <vpq1ukg82st.fsf@bauges.imag.fr>

On Fri, Jul 13, 2012 at 10:48:18AM +0200, Matthieu Moy wrote:

Show 14 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
> 
> > But is it really true that we want to error out on missing HOME if
> > we have usable XDG stuff?
> 
> Anyone else have an opinion on this?
> 
> In short, the question is whether
> 
>   export XDG_CONFIG_HOME=some-existing-dir
>   unset HOME
>   git config foo.baz boz
> 
> should die("$HOME is unset") or use the XDG config file.

What did previous versions of git do? From my reading of 21cf32279, the previous behavior was that if $HOME was not set, git would silently avoid reading from $HOME/.gitconfig entirely. Wouldn't dying be a huge regression?

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.