Re: [PATCHv6 1/4] Read (but not write) from $XDG_CONFIG_HOME/git/config file
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 7, 2012, 22:58 UTC
- Message-ID
- <7vpq9aenl0.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <1338988885-21933-1-git-send-email-Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr>
Show 13 quoted lines
> +char *mkpathdup(const char *fmt, ...)
> +{
> + char path[PATH_MAX];
> + va_list args;
> + unsigned len;
> +
> + va_start(args, fmt);
> + len = vsnprintf(path, sizeof(path), fmt, args);
> + va_end(args);
> + if (len >= sizeof(path))
> + return xstrdup(bad_path);
> + return xstrdup(cleanup_path(path));
> +}Hrmph. If a new helper is introduced anyway, wouldn't it be a better idea to get rid of the hardcoded PATH_MAX limitation, perhaps using strbuf_vaddf() or something in the implementation of this function?
Show 9 quoted lines
> diff --git a/t/t1306-xdg-files.sh b/t/t1306-xdg-files.sh > new file mode 100755 > index 0000000..5b971d9 > --- /dev/null > +++ b/t/t1306-xdg-files.sh > @@ -0,0 +1,70 @@ > ... > +test_expect_success 'read with --get: xdg file exists and ~/.gitconfig doesn'\''t' ' > + rm .gitconfig &&
"rm -f .gitconfig"; always consider the possibility that any part of the previous test could have been omitted or failed.