Re: [PATCH 0/4 v8] Git configuration directory

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 22, 2012, 21:19 UTC
Message-ID: <7vbokbnixy.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1340355806-6894-1-git-send-email-Matthieu.Moy@imag.fr>

Matthieu Moy <Matthieu.Moy@imag.fr> writes:

> I took the liberty of rewording the commit messages, and change a few
> words in the documentation (changed some "will be used" to "is used
> instead", which sounded more consistant with the context).

Thanks; the series overall looks good.

I may have made further tweaks by the time I push the result out. Please watch 'pu' and holler if you find anything objectionable.

Show 44 quoted lines

> A reminder of the context and objectives of the serie:
>
> Git currently stores its configuration file in ~/.gitconfig, which is
> nice and customary on Unix, as long as one has only one configuration
> file.
>
> But a typical user may want to store not only the config file, but
> also the files pointed to by core.excludesfile and
> core.attributesfile, which currently have no default values. To store
> several configuration files, it makes sense to have a configuration
> _directory_ instead of a set of configuration files, all right into
> $HOME. Calling this configuration directory ~/.git or ~/.gitconfig is
> not an option, since these paths already have another meaning. Using
> the XDG specification (in short: ~/.config/git) doesn't have this
> drawback, and allows the user to store his configuration files right
> next to files from other applications following the XDG standard.
>
> The first 3 patches add read support for this "configuration
> directory", and the last one gives opt-in write support, allowing
> users to make this "configuration directory" their way of life, and
> never hear again about ~/.gitconfig if (and only if) they do not want to.
>
> None of the patches change the behavior for people who do not create
> the new configuration files.
>
> Huynh Khoi Nguyen Nguyen (4):
>   config: read (but not write) from $XDG_CONFIG_HOME/git/config file
>   Let core.excludesfile default to $XDG_CONFIG_HOME/git/ignore
>   Let core.attributesfile default to $XDG_CONFIG_HOME/git/ignore
>   config: write to $XDG_CONFIG_HOME/git/config file if appropriate
>
>  Documentation/config.txt        |   8 +-
>  Documentation/git-config.txt    |  15 +++-
>  Documentation/gitattributes.txt |   2 +
>  Documentation/gitignore.txt     |   4 +-
>  attr.c                          |  17 +++--
>  builtin/config.c                |  25 ++++---
>  cache.h                         |   3 +
>  config.c                        |  23 +++---
>  dir.c                           |   7 +-
>  path.c                          |  41 +++++++++++
>  t/t1306-xdg-files.sh            | 158 ++++++++++++++++++++++++++++++++++++++++
>  11 files changed, 270 insertions(+), 33 deletions(-)
>  create mode 100755 t/t1306-xdg-files.sh