Re: [PATCHv6 1/4] Read (but not write) from $XDG_CONFIG_HOME/git/config file
- From
- nguyenhu@minatec.inpg.fr <nguyenhu@minatec.inpg.fr>
- Date
- Jun 10, 2012, 20:02 UTC
- Message-ID
- <20120610220239.Horde.UcGZQnwdC4BP1P1fPg1GEMA@webmail.minatec.grenoble-inp.fr>
- In-Reply-To
- <CABPQNSYd0hCU8nrfKJJjR+T_jQn4WC6jEaSCJPjKsuPdumEdtw@mail.gmail.com>
Erik Faye-Lund <kusmabite@gmail.com> a écrit :
Show 17 quoted lines
>> char *mkpathdup(const char *fmt, ...)
>> {
>> struct strbuf sb = STRBUF_INIT;
>> va_list args;
>>
>> va_start(args, fmt);
>> strbuf_vaddf(&sb, fmt, args);
>> va_end(args);
>>
>> return cleanup_path(strbuf_detach(&sb, NULL));
>>
>> }
>
> The awkward thing about doing this, is that the memory allocated by
> the strbuf cannot be reclaimed if you go with this. A pointer that has
> been adjusted (like cleanup_path can do) cannot be successfully fed to
> free.Do you mean that the previous version is preferable in keeping clean-up-path function ?