Re: [PATCH] config: fix several access(NULL) calls

From: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Date: Jul 16, 2012, 09:45 UTC
Message-ID: <vpqmx3011la.fsf@bauges.imag.fr>
In-Reply-To: <7vy5mn8v2k.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> 	if (use_global_config) {
>                 if (is $HOME/.gitconfig usable?) {
> 			use it;

Yes, but when $HOME is unset, the question doesn't really make sense. Maybe the file exists, but we can't know since the user broke his configuration by unsetting $HOME. The intent was to avoid writing to the XDG file unless it was very clear that the user wanted it, so in doubt, dying seems the best option.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.