Re: [PATCH 3/4 v8] Let core.attributesfile default to $XDG_CONFIG_HOME/git/ignore

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 25, 2012, 07:22 UTC
Message-ID: <7vlijbhn3x.fsf@alter.siamese.dyndns.org>
In-Reply-To: <vpqehp3j403.fsf@bauges.imag.fr>

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

Show 13 quoted lines

> Actually, it would even make sense to reduce the number of occurences of
> "excludes" in the UI, e.g. support something like core.ignoresfile as an
> alias for core.excludesfile, along the lines of:
>
> --- a/config.c
> +++ b/config.c
> @@ -723,7 +723,7 @@ static int git_default_core_config(const char *var, const char *value)
>         if (!strcmp(var, "core.askpass"))
>                 return git_config_string(&askpass_program, var, value);
>  
> -       if (!strcmp(var, "core.excludesfile"))
> +       if (!strcmp(var, "core.excludesfile") || !strcmp(var, "core.ignoresfile"))
>                 return git_config_pathname(&excludes_file, var, value);

I somehow suspect this is going backwards. ".gitignore" may have been the original mistake; it is much more than ".cvsignore".

But I do not deeply care either way. It just felt $path/git/ignore was out of place given $path/.git/info/exclude has been with us almost forever.