Re: [PATCHv5 2/4] Let core.excludesfile default to $XDG_CONFIG_HOME/git/ignore
- From
Matthieu Moy <matthieu.moy@grenoble-inp.fr>
- Date
- Jun 4, 2012, 11:43 UTC
- Message-ID
- <vpqpq9fs3oi.fsf@bauges.imag.fr>
- In-Reply-To
- <1338754481-27012-2-git-send-email-Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr>
Huynh Khoi Nguyen NGUYEN <Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr> writes:
> If core.excludesfile is not defined, its default value will be > $XDG_CONFIG_HOME/git/ignore in order to follow XDG specification. If > $XDG_CONFIG_HOME is either not set or emty, $HOME/.config will be > used.
It's not clear whether $HOME/.config will be used to replace $XDG_CONFIG_HOME or $XDG_CONFIG_HOME/git/ignore. I'd say explicitely $HOME/.config/git/ignore to avoid this.
Show 10 quoted lines
> --- a/Documentation/config.txt > +++ b/Documentation/config.txt > @@ -483,7 +483,9 @@ core.excludesfile:: > '.git/info/exclude', git looks into this file for patterns > of files which are not meant to be tracked. "`~/`" is expanded > to the value of `$HOME` and "`~user/`" to the specified user's > - home directory. See linkgit:gitignore[5]. > + home directory. Its default value is $XDG_CONFIG_HOME/git/ignore. > + If $XDG_CONFIG_HOME is either not set or empty, $HOME/.config will > + be used. See linkgit:gitignore[5].
Likewise.
Show 10 quoted lines
> --- a/Documentation/gitignore.txt > +++ b/Documentation/gitignore.txt > @@ -50,7 +50,9 @@ the repository but are specific to one user's workflow) should go into > the `$GIT_DIR/info/exclude` file. Patterns which a user wants git to > ignore in all situations (e.g., backup or temporary files generated by > the user's editor of choice) generally go into a file specified by > -`core.excludesfile` in the user's `~/.gitconfig`. > +`core.excludesfile` in the user's `~/.gitconfig`. Its default value is > +$XDG_CONFIG_HOME/git/ignore. If $XDG_CONFIG_HOME is either not set or empty, > +$HOME/.config will be used.
Likewise.
Otherwise, sounds good.
-- Matthieu Moy http://www-verimag.imag.fr/~moy/