From: Jeff King <peff@peff.net>
Date: Fri, 13 Jul 2012 13:00:22 GMT
Subject: Re: [PATCH] config: fix several access(NULL) calls
Message-ID: <20120713130021.GA2553@sigill.intra.peff.net>
In-Reply-To: <vpq1ukg82st.fsf@bauges.imag.fr>

On Fri, Jul 13, 2012 at 10:48:18AM +0200, Matthieu Moy wrote:

> Junio C Hamano <gitster@pobox.com> writes:
> 
> > But is it really true that we want to error out on missing HOME if
> > we have usable XDG stuff?
> 
> Anyone else have an opinion on this?
> 
> In short, the question is whether
> 
>   export XDG_CONFIG_HOME=some-existing-dir
>   unset HOME
>   git config foo.baz boz
> 
> should die("$HOME is unset") or use the XDG config file.

What did previous versions of git do? From my reading of 21cf32279, the
previous behavior was that if $HOME was not set, git would silently
avoid reading from $HOME/.gitconfig entirely. Wouldn't dying be a huge
regression?

-Peff