Re: [PATCHv6 4/4] Write to $XDG_CONFIG_HOME/git/config file
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 9, 2012, 06:19 UTC
- Message-ID
- <7vipf1aty2.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <CAJDDKr6sCrwy99-5-sOaAuNjYmnw73CicF3PyYMe8hvf38oFvg@mail.gmail.com>
David Aguilar <davvid@gmail.com> writes:
> I'm all for this change too.
Do you mean just the general direction, or including the implementation?
Show 13 quoted lines
> I did a little research RE: the OSX and Windows question. > > glib makes no differentiation between OSX and Linux, > but Windows does have its own #ifdef. > > http://git.gnome.org/browse/glib/tree/glib/gutils.c#n1251 > > I certainly don't think this should affect this series, > I'm just noting it as something that the Windows folks might > care about. Perhaps something for compat/ in the future? > > The downside to doing the same as glib is more documentation. > The upside is... consistency?
Probably. I think we should follow whatever existing and prevalent practice is, and my gut feeling is that we would end up first doing POSIX only thing in my tree, and msysgit folks will quickly feed me updates to tweak the behaviour to match what of Windows version.