Re: [PATCH 4/6] git svn: Fix launching of pager
Jonathan Nieder <jrnieder@gmail.com> wrote:
Show 19 quoted lines
> In commit dec543e (am -i, git-svn: use "git var GIT_PAGER"), I tried
> to teach git svn to defer to git var on what pager to use. In the
> process, I introduced two bugs:
>
> - The value set for $pager in config_pager has local scope, so
> run_pager never sees it;
>
> - git var cannot tell whether git svn’s output is going to a
> terminal, so the value chosen for $pager does not reflect that
> information.
>
> Fix them.
>
> Reported-by: Sebastian Celis <sebastian@sebastiancelis.com>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
> ---
> Oops. Eric, this bug is masked by another bug in "git var" whose fix
> is patch 2 from this series I sent to the list, but whatever happens,
> I think this is an improvement. Sorry for the breakage.
Thanks Jonathan, confirmed this works with patch 2 of this series.
Acked-by: Eric Wong <normalperson@yhbt.net>
--
Eric Wong