From: Eric Wong <normalperson@yhbt.net>
Date: Mon, 15 Feb 2010 07:58:24 GMT
Subject: Re: [PATCH 4/6] git svn: Fix launching of pager
Message-ID: <20100215075824.GA9997@dcvr.yhbt.net>
In-Reply-To: <20100214120610.GD3499@progeny.tock>

Jonathan Nieder <jrnieder@gmail.com> wrote:
> In commit dec543e (am -i, git-svn: use "git var GIT_PAGER"), I tried
> to teach git svn to defer to git var on what pager to use. In the
> process, I introduced two bugs:
> 
>  - The value set for $pager in config_pager has local scope, so
>    run_pager never sees it;
> 
>  - git var cannot tell whether git svn’s output is going to a
>    terminal, so the value chosen for $pager does not reflect that
>    information.
> 
> Fix them.
> 
> Reported-by: Sebastian Celis <sebastian@sebastiancelis.com>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
> ---
> Oops.  Eric, this bug is masked by another bug in "git var" whose fix
> is patch 2 from this series I sent to the list, but whatever happens,
> I think this is an improvement.  Sorry for the breakage.

Thanks Jonathan, confirmed this works with patch 2 of this series.

Acked-by: Eric Wong <normalperson@yhbt.net>

-- 
Eric Wong