Re: [PATCH v4 5/6] am: Fix launching of pager

From: Jeff King <peff@peff.net>
Date: Feb 15, 2010, 05:12 UTC
Message-ID: <20100215051248.GG3336@coredump.intra.peff.net>
In-Reply-To: <20100215050413.GA19586@progeny.tock>

On Sun, Feb 14, 2010 at 11:04:13PM -0600, Jonathan Nieder wrote:

Show 11 quoted lines

> Jeff King wrote:
> > On Sun, Feb 14, 2010 at 09:25:33PM -0600, Jonathan Nieder wrote:
> 
> >> +		if tty <&1 >/dev/null 2>/dev/null
> >
> > We seem to use "test -t 1" for this elsewhere, and I don't see us using
> > "tty" anywhere else. It is POSIX, and I tested that even Solaris 8 and
> > AIX 6.1 have it. So I don't think it is a portability issue, but others
> > may know more than I.
> 
> tty is portable, but "test -t 1" is cleaner.  Thanks for the pointer.

There is another one in the test script in patch 6/6, btw.

-Peff